Changeset 36145

Timestamp:

01/02/2016 03:33:15 AM (9 years ago)

Author:

dd32

Message:

Admin: Restore the "Show advanced menu properties" checkboxes IDs.
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.

Merge [36137] to the 4.4 branch.
Props afercia.
Fixes #35112.

Location:

branches/4.4

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-screen.php (modified) (2 diffs)
• src/wp-admin/js/postbox.js (modified) (2 diffs)

branches/4.4/src/wp-admin/includes/class-wp-screen.php

@@ -999 +999 @@
          *
          * @since 4.4.0
-         * 
+         *
          * @param bool      $show_button Whether to show Screen Options submit button.
          *                               Default false.
@@ -1088 +1088 @@
             $id = "$column-hide";
             echo '<label>';
-            echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" value="' . $column . '"' . checked( ! in_array( $column, $hidden ), true, false ) . ' />';
+            echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '"' . checked( ! in_array( $column, $hidden ), true, false ) . ' />';
             echo "$title</label>\n";
         }

branches/4.4/src/wp-admin/js/postbox.js

@@ -51 +51 @@
             this.init( page, args );
 
-            $handles.on( 'click.postboxes',  this.handle_click );
+            $handles.on( 'click.postboxes', this.handle_click );
 
             $('.postbox .hndle a').click( function(e) {
@@ -145 +145 @@
 
         save_state : function(page) {
-            var closed = $('.postbox').filter('.closed').map(function() { return this.id; }).get().join(','),
-                hidden = $('.postbox').filter(':hidden').map(function() { return this.id; }).get().join(',');
+            var closed, hidden;
+
+            // Return on the nav-menus.php screen, see #35112.
+            if ( 'nav-menus' === page ) {
+                return;
+            }
+
+            closed = $( '.postbox' ).filter( '.closed' ).map( function() { return this.id; } ).get().join( ',' );
+            hidden = $( '.postbox' ).filter( ':hidden' ).map( function() { return this.id; } ).get().join( ',' );
 
             $.post(ajaxurl, {