Changeset 36219

Timestamp:

01/07/2016 06:43:11 PM (9 years ago)

Author:

westonruter

Message:

Customizer: Improve _doing_it_wrong() message when widgets or nav_menus are manually removed via WP_Customize_Manager::remove_panel().

• Link to code reference page for customize_loaded_components instead of linking to a Trac comment.
• Remove HTML code from being included in translated string.
• Add missing translator comment for the specifiers in the translated string.

Amends [36216].
Props DrewAPicture.
Fixes #35242.

File:

• trunk/src/wp-includes/class-wp-customize-manager.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -1203 +1203 @@
             'nav_menus',
         );
+
         if ( in_array( $id, $core_panels, true ) ) {
-            $url = 'https://core.trac.wordpress.org/ticket/33552#comment:12';
-            _doing_it_wrong(
-                __METHOD__,
-                sprintf( __( 'Removing %1$s manually will cause PHP warnings. Use the <code>customize_loaded_components</code> filter instead. See <a href="%2$s">%2$s</a>.' ), $id, $url ),
-                '4.5'
+            /* translators: 1: panel id, 2: filter reference URL, 3: filter name */
+            $message = sprintf( __( 'Removing %1$s manually will cause PHP warnings. Use the <a href="%2$s">%3$s</a> filter instead.' ),
+                $id,
+                esc_url( 'https://developer.wordpress.org/reference/hooks/customize_loaded_components/' ),
+                '<code>customize_loaded_components</code>'
             );
+
+            _doing_it_wrong( __METHOD__, $message, '4.5' );
         }
         unset( $this->panels[ $id ] );