Changeset 36233

Timestamp:

01/09/2016 02:21:28 AM (9 years ago)

Author:

azaozz

Message:

Media: fix undefined error that prevents showing a preview in the media modal when replacing video or audio.

Fixes #35363.

Location:

trunk/src/wp-includes/js

Files:

• media-audiovideo.js (modified) (2 diffs)
• media/views/media-details.js (modified) (2 diffs)

trunk/src/wp-includes/js/media-audiovideo.js

@@ -793 +793 @@
      */
     setPlayer : function() {
-        var baseSettings;
+        var baseSettings, src;
 
         if ( this.players.length || ! this.media || this.scriptXhr ) {
@@ -799 +799 @@
         }
 
-        if ( this.model.get( 'src' ).indexOf( 'vimeo' ) > -1 && ! ( 'Froogaloop' in window ) ) {
+        src = this.model.get( 'src' );
+
+        if ( src && src.indexOf( 'vimeo' ) > -1 && ! ( 'Froogaloop' in window ) ) {
             baseSettings = wp.media.mixin.mejsSettings;
             this.scriptXhr = $.getScript( baseSettings.pluginPath + 'froogaloop.min.js', _.bind( this.loadPlayer, this ) );

trunk/src/wp-includes/js/media/views/media-details.js

@@ -88 +88 @@
      */
     setPlayer : function() {
-        var baseSettings;
+        var baseSettings, src;
 
         if ( this.players.length || ! this.media || this.scriptXhr ) {
@@ -94 +94 @@
         }
 
-        if ( this.model.get( 'src' ).indexOf( 'vimeo' ) > -1 && ! ( 'Froogaloop' in window ) ) {
+        src = this.model.get( 'src' );
+
+        if ( src && src.indexOf( 'vimeo' ) > -1 && ! ( 'Froogaloop' in window ) ) {
             baseSettings = wp.media.mixin.mejsSettings;
             this.scriptXhr = $.getScript( baseSettings.pluginPath + 'froogaloop.min.js', _.bind( this.loadPlayer, this ) );