Changeset 36275 for trunk/src/wp-includes/comment-template.php

Timestamp:

01/13/2016 03:12:34 AM (9 years ago)

Author:

boonebgorges

Message:

Ignore hierarchy in pagination calculation when comment threading is disabled.

In order to calculate comment pagination when newest comments are displayed
first, comments_template() must perform a separate query to determine the
total number of paginating comments available on a post. See [34729], #8071,
pagination calculation - can be defined as a top-level comment, or a comment
with parent=0. However, when comment threading is disabled, yet comments
exist in the database that have parents, all comments - even those with a
parent - are "paginating". (This typically happens when comments threading was
once enabled, but has since been turned off.) As such, the total-paginating-
comments query should only be limited to top-level comments when
'thread_comments' is disabled.

Props jmdodd.
Fixes #35419.

File:

• trunk/src/wp-includes/comment-template.php (modified) (1 diff)

trunk/src/wp-includes/comment-template.php

@@ -1324 +1324 @@
                 'orderby' => false,
                 'post_id' => $post->ID,
-                'parent'  => 0,
                 'status'  => 'approve',
             );
+
+            if ( $comment_args['hierarchical'] ) {
+                $top_level_args['parent'] = 0;
+            }
 
             if ( isset( $comment_args['include_unapproved'] ) ) {