Changeset 36307 for trunk/tests/phpunit/tests/oembed/postEmbedUrl.php

Timestamp:

01/15/2016 07:55:19 AM (4 years ago)

Author:

swissspidy

Message:

Embeds: Allow embedding static front pages and pages having a child page with an embed slug.

This makes embed a special slug that can't be used for new pages/posts. When https://example.com/foo/embed/ is an existing page, embeds fall back to https://example.com/foo/?embed=true.
Adds unit tests.

Fixes #34971.

File:

• trunk/tests/phpunit/tests/oembed/postEmbedUrl.php (modified) (3 diffs)

trunk/tests/phpunit/tests/oembed/postEmbedUrl.php

@@ -5 +5 @@
  */
 class Tests_Post_Embed_URL extends WP_UnitTestCase {
-    function test_get_post_embed_url_non_existent_post() {
+    function test_non_existent_post() {
         $embed_url = get_post_embed_url( 0 );
         $this->assertFalse( $embed_url );
     }
 
-    function test_get_post_embed_url_with_pretty_permalinks() {
-        update_option( 'permalink_structure', '/%postname%' );
+    function test_with_pretty_permalinks() {
+        $this->set_permalink_structure( '/%postname%' );
 
         $post_id   = self::factory()->post->create();
@@ -17 +17 @@
         $embed_url = get_post_embed_url( $post_id );
 
-        $this->assertEquals( user_trailingslashit( trailingslashit( $permalink ) . 'embed' ), $embed_url );
-
-        update_option( 'permalink_structure', '' );
+        $this->assertEquals( $permalink . '/embed', $embed_url );
     }
 
-    function test_get_post_embed_url_with_ugly_permalinks() {
+    function test_with_ugly_permalinks() {
         $post_id   = self::factory()->post->create();
         $permalink = get_permalink( $post_id );
@@ -29 +27 @@
         $this->assertEquals( $permalink . '&embed=true', $embed_url );
     }
+
+    /**
+     * @ticket 34971
+     */
+    function test_static_front_page() {
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
+
+        update_option( 'show_on_front', 'page' );
+        update_option( 'page_on_front', $post_id );
+
+        $embed_url = get_post_embed_url( $post_id );
+
+        $this->assertSame( user_trailingslashit( trailingslashit( home_url() ) . 'embed' ), $embed_url );
+
+        update_option( 'show_on_front', 'posts' );
+    }
+
+    /**
+     * @ticket 34971
+     */
+    function test_static_front_page_with_ugly_permalinks() {
+        $post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
+
+        update_option( 'show_on_front', 'page' );
+        update_option( 'page_on_front', $post_id );
+
+        $embed_url = get_post_embed_url( $post_id );
+
+        $this->assertSame( trailingslashit( home_url() ) . '?embed=true', $embed_url );
+
+        update_option( 'show_on_front', 'posts' );
+    }
+
+    /**
+     * @ticket 34971
+     */
+    function test_page_conflicts_with_embed_slug() {
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $parent_page = self::factory()->post->create( array( 'post_type' => 'page' ) );
+
+        add_filter( 'wp_unique_post_slug', array( $this, 'filter_unique_post_slug' ) );
+        $child_page = self::factory()->post->create( array(
+            'post_type'   => 'page',
+            'post_parent' => $parent_page,
+            'post_name'   => 'embed',
+        ) );
+        remove_filter( 'wp_unique_post_slug', array( $this, 'filter_unique_post_slug' ) );
+
+        $this->assertSame( get_permalink( $parent_page ) . '?embed=true', get_post_embed_url( $parent_page ) );
+        $this->assertSame( get_permalink( $child_page ) . 'embed/', get_post_embed_url( $child_page ) );
+    }
+
+    /**
+     * @ticket 34971
+     */
+    function test_static_front_page_conflicts_with_embed_slug() {
+        $this->set_permalink_structure( '/%postname%/' );
+
+        // Create a post with the 'embed' post_name
+        add_filter( 'wp_unique_post_slug', array( $this, 'filter_unique_post_slug' ) );
+        $post_embed_slug = self::factory()->post->create( array( 'post_name' => 'embed' ) );
+        remove_filter( 'wp_unique_post_slug', array( $this, 'filter_unique_post_slug' ) );
+        $page_front = self::factory()->post->create( array( 'post_type' => 'page' ) );
+
+        update_option( 'show_on_front', 'page' );
+        update_option( 'page_on_front', $page_front );
+
+        $this->assertSame( home_url() . '/embed/embed/', get_post_embed_url( $post_embed_slug ) );
+        $this->assertSame( home_url() . '/?embed=true', get_post_embed_url( $page_front ) );
+
+        update_option( 'show_on_front', 'posts' );
+    }
+
+    public function filter_unique_post_slug() {
+        return 'embed';
+    }
 }