Changeset 36323

Timestamp:

01/15/2016 07:34:16 PM (9 years ago)

Author:

boonebgorges

Message:

Populate term cache with proper clone of term objects.

[34999] modified the cache strategy for terms in the context of
wp_get_object_terms(). As part of these changes, the object_id property of
term objects had to be unset before being cached. To avoid modifying passed-by-
reference terms, update_term_cache() attempted to make a copy of the terms
passed to the function; however, it failed to use the clone keyword, and thus
only created a reference instead of a copy.

Props berengerzyla.
Fixes #35462.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (1 diff)
• tests/phpunit/tests/term/cache.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -3722 +3722 @@
     foreach ( (array) $terms as $term ) {
         // Create a copy in case the array was passed by reference.
-        $_term = $term;
+        $_term = clone $term;
 
         // Object ID should not be cached.

trunk/tests/phpunit/tests/term/cache.php

@@ -201 +201 @@
         _unregister_taxonomy( 'wptests_tax' );
     }
+
+    /**
+     * @ticket 35462
+     */
+    public function test_term_objects_should_not_be_modified_by_update_term_cache() {
+        register_taxonomy( 'wptests_tax', 'post' );
+        $t = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+        $p = self::factory()->post->create();
+
+        wp_set_object_terms( $p, $t, 'wptests_tax' );
+
+        $terms = wp_get_object_terms( $p, 'wptests_tax', array( 'fields' => 'all_with_object_id' ) );
+
+        update_term_cache( $terms );
+
+        foreach ( $terms as $term ) {
+            $this->assertSame( $p, $term->object_id );
+        }
+    }
 }