Changeset 36323 for trunk/src/wp-includes/taxonomy.php

Timestamp:

01/15/2016 07:34:16 PM (9 years ago)

Author:

boonebgorges

Message:

Populate term cache with proper clone of term objects.

[34999] modified the cache strategy for terms in the context of
wp_get_object_terms(). As part of these changes, the object_id property of
term objects had to be unset before being cached. To avoid modifying passed-by-
reference terms, update_term_cache() attempted to make a copy of the terms
passed to the function; however, it failed to use the clone keyword, and thus
only created a reference instead of a copy.

Props berengerzyla.
Fixes #35462.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -3722 +3722 @@
     foreach ( (array) $terms as $term ) {
         // Create a copy in case the array was passed by reference.
-        $_term = $term;
+        $_term = clone $term;
 
         // Object ID should not be cached.