Changeset 36325

Timestamp:

01/15/2016 08:09:08 PM (9 years ago)

Author:

rachelbaker

Message:

Comments: Use TEXT column type in fallback for wp_get_comment_column_max_length().

Fixes #10377.

Location:

trunk

Files:

• src/wp-includes/comment.php (modified) (1 diff)
• tests/phpunit/tests/comment.php (modified) (1 diff)

trunk/src/wp-includes/comment.php

@@ -967 +967 @@
         $max_length = (int) $col_length['length'];
     } else {
-        $max_length = 255;
+        // Assume a TEXT column, 65535 - 10.
+        $max_length = 65525;
     }
 

trunk/tests/phpunit/tests/comment.php

@@ -673 +673 @@
         $this->assertSame( 'SHIELD_AGENT', $updated->comment_agent );
     }
+
+    public function test_wp_get_comment_column_max_length() {
+        $columns = array(
+            'comment_author' => 245,
+            'comment_author_email' => 100,
+            'comment_author_url' => 200,
+            'comment_author_IP' => 100,
+            'comment_content' => 65525,
+            'comment_approved' => 20,
+            'comment_agent' => 255,
+            'comment_type' => 20,
+        );
+
+        foreach ( $columns as $column => $expected ) {
+            $max_length = wp_get_comment_column_max_length( $column );
+            $this->assertSame( $expected, $max_length );
+        }
+    }
 }