Changeset 36345

Timestamp:

01/19/2016 02:54:28 AM (9 years ago)

Author:

boonebgorges

Message:

Ignore false values of 'search' in WP_Comment_Query.

Props danielbachhuber.
Fixes #35513.

Location:

trunk

Files:

• src/wp-includes/class-wp-comment-query.php (modified) (1 diff)
• tests/phpunit/tests/comment/query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -746 +746 @@
         }
 
-        if ( '' !== $this->query_vars['search'] ) {
+        // Falsy search strings are ignored.
+        if ( strlen( $this->query_vars['search'] ) ) {
             $search_sql = $this->get_search_sql(
                 $this->query_vars['search'],

trunk/tests/phpunit/tests/comment/query.php

@@ -1180 +1180 @@
     }
 
+    /**
+     * @ticket 35513
+     */
+    public function test_search_false_should_be_ignored() {
+        $q = new WP_Comment_Query();
+        $q->query( array(
+            'search' => false,
+        ) );
+        $this->assertNotContains( "comment_author LIKE", $q->request );
+    }
+
+    /**
+     * @ticket 35513
+     */
+    public function test_search_null_should_be_ignored() {
+        $q = new WP_Comment_Query();
+        $q->query( array(
+            'search' => null,
+        ) );
+        $this->assertNotContains( "comment_author LIKE", $q->request );
+    }
+
+    /**
+     * @ticket 35513
+     */
+    public function test_search_empty_string_should_be_ignored() {
+        $q = new WP_Comment_Query();
+        $q->query( array(
+            'search' => false,
+        ) );
+        $this->assertNotContains( "comment_author LIKE", $q->request );
+    }
+
+    /**
+     * @ticket 35513
+     */
+    public function test_search_int_0_should_not_be_ignored() {
+        $q = new WP_Comment_Query();
+        $q->query( array(
+            'search' => 0,
+        ) );
+        $this->assertContains( "comment_author LIKE '%0%'", $q->request );
+    }
+
+    /**
+     * @ticket 35513
+     */
+    public function test_search_string_0_should_not_be_ignored() {
+        $q = new WP_Comment_Query();
+        $q->query( array(
+            'search' => '0',
+        ) );
+        $this->assertContains( "comment_author LIKE '%0%'", $q->request );
+    }
+
     public function test_orderby_default() {
         global $wpdb;