Changeset 36348 for trunk/tests/phpunit/tests/term/getTerms.php

Timestamp:

01/19/2016 04:09:32 AM (11 years ago)

Author:

boonebgorges

Message:

Don't double-escape the 'name' param in get_terms().

[32353] changed the way the 'name' param in get_terms() is sanitized, by
running it through sanitize_term_field( 'name' ) before performing the SQL
query. An unintentional side effect of this change was that the string is
double-escaped: once by wp_filter_kses(), and once by esc_sql(). The
double-escaping was causing 'name' queries to fail when the param contained
apostrophes or other escaped characters.

Fixes #35493.

File:

• trunk/tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/getTerms.php

@@ -560 +560 @@
                         'name' => array( 'Foo & Bar' ),
                 ) );
+                $this->assertEqualSets( array( $t ), $found );
+        }
+
+        /**
+         * @ticket 35493
+         */
+        public function test_name_should_not_double_escape_apostrophes() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $name = "Foo'Bar";
+
+                $t = self::factory()->term->create( array(
+                        'taxonomy' => 'wptests_tax',
+                        'name' => $name,
+                ) );
+
+                $term = get_term( $t, 'wptests_tax' );
+
+                $this->assertSame( $name, $term->name );
+
+                $found = get_terms( 'wptests_tax', array(
+                        'hide_empty' => false,
+                        'fields' => 'ids',
+                        'name' => $name,
+                ) );
+
                 $this->assertEqualSets( array( $t ), $found );
         }