WordPress.org

Make WordPress Core


Ignore:
Timestamp:
01/20/2016 08:32:00 AM (5 years ago)
Author:
dd32
Message:

Comments: Ignore hierarchy in pagination calculation when comment threading is disabled.

In order to calculate comment pagination when newest comments are displayed
first, comments_template() must perform a separate query to determine the
total number of paginating comments available on a post. See [34729], #8071,
pagination calculation - can be defined as a top-level comment, or a comment
with parent=0. However, when comment threading is disabled, yet comments
exist in the database that have parents, all comments - even those with a
parent - are "paginating". (This typically happens when comments threading was
once enabled, but has since been turned off.) As such, the total-paginating-
comments query should only be limited to top-level comments when
'thread_comments' is disabled.

Merges [36275] to the 4.4 branch.
Props jmdodd.
Fixes #35419.

Location:
branches/4.4
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/4.4

  • branches/4.4/src/wp-includes/comment-template.php

    r36360 r36362  
    13231323                'orderby' => false,
    13241324                'post_id' => $post->ID,
    1325                 'parent'  => 0,
    13261325                'status'  => 'approve',
    13271326            );
     1327
     1328            if ( $comment_args['hierarchical'] ) {
     1329                $top_level_args['parent'] = 0;
     1330            }
    13281331
    13291332            if ( isset( $comment_args['include_unapproved'] ) ) {
Note: See TracChangeset for help on using the changeset viewer.