Changeset 36403

Timestamp:

01/26/2016 02:55:15 AM (11 years ago)

Author:

boonebgorges

Message:

Introduce $comment_status and $ping_status params for WP_Query.

Props birgire.
Fixes #35601.

Location:

trunk

Files:

• src/wp-includes/query.php (modified) (4 diffs)
• tests/phpunit/tests/query.php (modified) (1 diff)

trunk/src/wp-includes/query.php

@@ -1485 +1485 @@
          *              search terms, by prepending a hyphen.
          * @since 4.5.0 Removed the `$comments_popup` parameter.
+         *              Introduced the `$comment_status` and `$ping_status` parameters.
          * @access public
          *
@@ -1501 +1502 @@
          *     @type array        $category__not_in        An array of category IDs (NOT in).
          *     @type string       $category_name           Use category slug (not name, this or any children).
+         *     @type string       $comment_status          Comment status.
          *     @type int          $comments_per_page       The number of comments to return per page.
          *                                                 Default 'comments_per_page' option.
@@ -1546 +1548 @@
          *     @type string       $pagename                Page slug.
          *     @type string       $perm                    Show posts if user has the appropriate capability.
+         *     @type string       $ping_status             Ping status.
          *     @type array        $post__in                An array of post IDs to retrieve, sticky posts will be included
          *     @type string       $post_mime_type          The mime type of the post. Used for 'attachment' post_type.
@@ -3037 +3040 @@
                 }
 
+                if ( ! empty( $q['comment_status'] ) ) {
+                        $where .= $wpdb->prepare( " AND $wpdb->posts.comment_status = %s ", $q['comment_status'] );
+                }
+
+                if ( ! empty( $q['ping_status'] ) )  {
+                        $where .= $wpdb->prepare( " AND $wpdb->posts.ping_status = %s ", $q['ping_status'] );
+                }
+
                 if ( 'any' == $post_type ) {
                         $in_search_post_types = get_post_types( array('exclude_from_search' => false) );

trunk/tests/phpunit/tests/query.php

@@ -493 +493 @@
                 $this->assertContains( 'LIMIT 5, 5', $q->request );
         }
+
+        /**
+         * @ticket 35601
+         */
+        public function test_comment_status() {
+                $p1 = self::factory()->post->create( array( 'comment_status' => 'open' ) );
+                $p2 = self::factory()->post->create( array( 'comment_status' => 'closed' ) );
+
+                $q = new WP_Query( array(
+                        'fields' => 'ids',
+                        'comment_status' => 'closed',
+                ) );
+
+                $this->assertSame( array( $p2 ), $q->posts );
+        }
+
+        /**
+         * @ticket 35601
+         */
+        public function test_ping_status() {
+                $p1 = self::factory()->post->create( array( 'ping_status' => 'open' ) );
+                $p2 = self::factory()->post->create( array( 'ping_status' => 'closed' ) );
+
+                $q = new WP_Query( array(
+                        'fields' => 'ids',
+                        'ping_status' => 'closed',
+                ) );
+
+                $this->assertSame( array( $p2 ), $q->posts );
+        }
 }