Changeset 36420

Timestamp:

01/29/2016 04:51:11 AM (9 years ago)

Author:

boonebgorges

Message:

Simplify action placement in update_metadata().

By combining a number of foreach loops, we make the code more readable and
potentially faster in the case where many metadata rows are being updated.

Props Shelob9.
Fixes #35652.

File:

• trunk/src/wp-includes/meta.php (modified) (2 diffs)

trunk/src/wp-includes/meta.php

@@ -228 +228 @@
          */
         do_action( "update_{$meta_type}_meta", $meta_id, $object_id, $meta_key, $_meta_value );
-    }
-
-    if ( 'post' == $meta_type ) {
-        foreach ( $meta_ids as $meta_id ) {
+
+        if ( 'post' == $meta_type ) {
             /**
              * Fires immediately before updating a post's metadata.
@@ -267 +265 @@
          */
         do_action( "updated_{$meta_type}_meta", $meta_id, $object_id, $meta_key, $_meta_value );
-    }
-
-    if ( 'post' == $meta_type ) {
-        foreach ( $meta_ids as $meta_id ) {
+
+        if ( 'post' == $meta_type ) {
             /**
              * Fires immediately after updating a post's metadata.