Changeset 36479

Timestamp:

02/05/2016 06:35:47 PM (10 years ago)

Author:

boonebgorges

Message:

Comments: Add 'parentin' and 'parentnot_in' to query var defaults.

Query var defaults are used to calculate a cache key. The fact that these
params were not listed among the defaults was causing cache keys to be
insufficiently specific.

Props danielbachhuber.
Fixes #35677.

Location:

trunk

Files:

• src/wp-includes/class-wp-comment-query.php (modified) (1 diff)
• tests/phpunit/tests/comment/query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -274 +274 @@
             'order' => 'DESC',
             'parent' => '',
+            'parent__in' => '',
+            'parent__not_in' => '',
             'post_author__in' => '',
             'post_author__not_in' => '',

trunk/tests/phpunit/tests/comment/query.php

@@ -1866 +1866 @@
 
     /**
+     * @ticket 35677
+     */
+    public function test_cache_should_be_sensitive_to_parent__in() {
+        global $wpdb;
+
+        $q1 = new WP_Comment_Query( array(
+            'parent__in' => array( 1, 2, 3 ),
+        ) );
+
+        $num_queries = $wpdb->num_queries;
+
+        $q2 = new WP_Comment_Query( array(
+            'parent__in' => array( 4, 5, 6 ),
+        ) );
+
+        $this->assertNotEquals( $num_queries, $wpdb->num_queries );
+    }
+
+    /**
+     * @ticket 35677
+     */
+    public function test_cache_should_be_sensitive_to_parent__not_in() {
+        global $wpdb;
+
+        $q1 = new WP_Comment_Query( array(
+            'parent__not_in' => array( 1, 2, 3 ),
+        ) );
+
+        $num_queries = $wpdb->num_queries;
+
+        $q2 = new WP_Comment_Query( array(
+            'parent__not_in' => array( 4, 5, 6 ),
+        ) );
+
+        $this->assertNotEquals( $num_queries, $wpdb->num_queries );
+    }
+
+    /**
      * @ticket 32762
      */