Changeset 36480 for trunk/src/wp-includes/class-wp-comment-query.php

Timestamp:

02/05/2016 06:49:46 PM (10 years ago)

Author:

boonebgorges

Message:

Comments: Restore the ability to bypass post_id filter using 0 or '0'.

The changes introduced in [36381], while logical and clearly awesome, introduce
the potential for much breakage. Those who want to query for comments with a
null comment_post_ID should use 'post_in' => array( 0 ) instead.

Reverts [36381], [36387].
See #35090.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -215 +215 @@
      *     @type int          $post_ID                   Currently unused.
      *     @type int          $post_id                   Limit results to those affiliated with a given post ID.
-     *                                                   Default null.
+     *                                                   Default 0.
      *     @type array        $post__in                  Array of post IDs to include affiliated comments for.
      *                                                   Default empty.
@@ -279 +279 @@
             'post_author__not_in' => '',
             'post_ID' => '',
-            'post_id' => null,
+            'post_id' => 0,
             'post__in' => '',
             'post__not_in' => '',
@@ -648 +648 @@
         }
 
-        if ( strlen( $this->query_vars['post_id'] ) ) {
-            $this->sql_clauses['where']['post_id'] = $wpdb->prepare( 'comment_post_ID = %d', $this->query_vars['post_id'] );
+        $post_id = absint( $this->query_vars['post_id'] );
+        if ( ! empty( $post_id ) ) {
+            $this->sql_clauses['where']['post_id'] = $wpdb->prepare( 'comment_post_ID = %d', $post_id );
         }