Changeset 36482

Timestamp:

02/05/2016 07:02:51 PM (9 years ago)

Author:

boonebgorges

Message:

When updating a user, invalidate its 'userslugs' cache.

user_nicename can be changed via wp_update_user(), so we invalidate just
to be safe.

Props thebrandonallen.
Fixes #35750.

Location:

trunk

Files:

• src/wp-includes/user.php (modified) (1 diff)
• tests/phpunit/tests/user.php (modified) (1 diff)

trunk/src/wp-includes/user.php

@@ -1683 +1683 @@
 
     wp_cache_delete( $user['user_email'], 'useremail' );
+    wp_cache_delete( $user['user_nicename'], 'userslugs' );
 
     // Merge old and new fields with new fields overwriting old ones.

trunk/tests/phpunit/tests/user.php

@@ -901 +901 @@
 
         $this->assertWPError( $u );
+    }
+
+    /**
+     * @ticket 35750
+     */
+    public function test_wp_update_user_should_delete_userslugs_cache() {
+        $u = self::factory()->user->create();
+        $user = get_userdata( $u );
+
+        wp_update_user( array(
+            'ID' => $u,
+            'user_nicename' => 'newusernicename',
+        ) );
+        $updated_user = get_userdata( $u );
+
+        $this->assertFalse( wp_cache_get( $user->user_nicename, 'userslugs' ) );
+        $this->assertEquals( $u, wp_cache_get( $updated_user->user_nicename, 'userslugs' ) );
     }