Changeset 36509

Timestamp:

02/11/2016 05:34:59 PM (9 years ago)

Author:

boonebgorges

Message:

Don't double-unslash meta key when update_metadata() falls back on add_metadata().

Props jdgrimes.
Fixes #35795.

Location:

trunk

Files:

• src/wp-includes/meta.php (modified) (2 diffs)
• tests/phpunit/tests/meta/updateMetadata.php (added)

trunk/src/wp-includes/meta.php

@@ -162 +162 @@
 
     // expected_slashed ($meta_key)
+    $raw_meta_key = $meta_key;
     $meta_key = wp_unslash($meta_key);
     $passed_value = $meta_value;
@@ -199 +200 @@
     $meta_ids = $wpdb->get_col( $wpdb->prepare( "SELECT $id_column FROM $table WHERE meta_key = %s AND $column = %d", $meta_key, $object_id ) );
     if ( empty( $meta_ids ) ) {
-        return add_metadata($meta_type, $object_id, $meta_key, $passed_value);
+        return add_metadata( $meta_type, $object_id, $raw_meta_key, $passed_value );
     }