WordPress.org

Make WordPress Core


Ignore:
Timestamp:
02/11/2016 07:07:30 PM (4 years ago)
Author:
ericlewis
Message:

Menus: Allow larger menus to be created in the Edit Menu screen.

In the Edit Menu screen, each menu item creates 11 form input elements. In menus with more than 71 menu items, often items after the 71st weren't saved. This was because PHP's runtime configuration max_input_vars default value is 1000. Large menus exceed this, so PHP didn't populate the $_POST superglobal for the latter menu items.

The entire form is now JSON-encoded into a single input which populates $_POST manually on form submission.

This was attempted previously in [36506] which was reverted in [36507]. Some form fields were not being slurped into the form's JSON representation, and it did not scale for a site with many posts. This approach fixes those problems.

Props ocean90, afercia.
See #14134.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/nav-menus.php

    r36507 r36510  
    5050$action = isset( $_REQUEST['action'] ) ? $_REQUEST['action'] : 'edit';
    5151
     52/*
     53 * If a JSON blob of navigation menu data is found, expand it and inject it
     54 * into `$_POST` to avoid PHP `max_input_vars` limitations. See #14134.
     55 */
     56if ( isset( $_POST['nav-menu-data'] ) ) {
     57    $data = json_decode( stripslashes( $_POST['nav-menu-data'] ) );
     58    if ( ! is_null( $data ) && $data ) {
     59        foreach ( $data as $post_input_data ) {
     60            // For input names that are arrays (e.g. `menu-item-db-id[3]`), derive the array path keys via regex.
     61            if ( preg_match( '#(.*)(?:\[(\d+)\])#', $post_input_data->name, $matches ) ) {
     62                if ( empty( $_POST[$matches[1]] ) ) {
     63                    $_POST[$matches[1]] = array();
     64                }
     65                $_POST[$matches[1]][(int)$matches[2]] = $post_input_data->value;
     66            } else {
     67                $_POST[$post_input_data->name] = $post_input_data->value;
     68            }
     69        }
     70    }
     71}
    5272switch ( $action ) {
    5373    case 'add-menu-item':
     
    732752            <form id="update-nav-menu" method="post" enctype="multipart/form-data">
    733753                <div class="menu-edit <?php if ( $add_new_screen ) echo 'blank-slate'; ?>">
     754                    <input type="hidden" name="nav-menu-data">
    734755                    <?php
    735756                    wp_nonce_field( 'closedpostboxes', 'closedpostboxesnonce', false );
Note: See TracChangeset for help on using the changeset viewer.