Changeset 36511 for trunk/src/wp-includes/meta.php

Timestamp:

02/12/2016 02:46:28 AM (9 years ago)

Author:

boonebgorges

Message:

In delete_metadata(), only invalidate cache for affected objects.

The $delete_all flag in delete_metadata() triggers cache invalidation for
multiple objects. Previously, invalidation took place for all objects matching
the $meta_key parameter, regardless of whether $meta_value was also set.
This resulted in overly aggressive invalidation.

Props rahal.aboulfeth.
Fixes #35797.

File:

• trunk/src/wp-includes/meta.php (modified) (1 diff)

trunk/src/wp-includes/meta.php

@@ -364 +364 @@
         return false;
 
-    if ( $delete_all )
-        $object_ids = $wpdb->get_col( $wpdb->prepare( "SELECT $type_column FROM $table WHERE meta_key = %s", $meta_key ) );
+    if ( $delete_all ) {
+        $value_clause = '';
+        if ( '' !== $meta_value && null !== $meta_value && false !== $meta_value ) {
+            $value_clause = $wpdb->prepare( " AND meta_value = %s", $meta_value );
+        }
+
+        $object_ids = $wpdb->get_col( $wpdb->prepare( "SELECT $type_column FROM $table WHERE meta_key = %s $value_clause", $meta_key ) );
+    }
 
     /**