Changeset 36514 for trunk/tests/phpunit/tests/comment.php

Timestamp:

02/12/2016 01:54:50 PM (10 years ago)

Author:

rachelbaker

Message:

Comments: Change wp_get_comment_column_max_length() function to wp_get_comment_fields_max_lengths() for consolidation and better fallbacks.

Instead of returning a value for each of the related table column lengths, return an array of all of the column lengths used in the comment form.
Better fallback handling, where each field falls back to the expected max_length instead of an arbitrary number.

Props azaozz.

Fixes #10377.

File:

• trunk/tests/phpunit/tests/comment.php (modified) (1 diff)

trunk/tests/phpunit/tests/comment.php

@@ -674 +674 @@
     }
 
-    public function test_wp_get_comment_column_max_length() {
-        $columns = array(
-            'comment_author' => 245,
-            'comment_author_email' => 100,
-            'comment_author_url' => 200,
-            'comment_author_IP' => 100,
-            'comment_content' => 65525,
-            'comment_approved' => 20,
-            'comment_agent' => 255,
-            'comment_type' => 20,
-        );
-
-        foreach ( $columns as $column => $expected ) {
-            $max_length = wp_get_comment_column_max_length( $column );
-            $this->assertSame( $expected, $max_length );
-        }
-    }
 }