Changeset 36523

Timestamp:

02/13/2016 12:11:24 AM (9 years ago)

Author:

westonruter

Message:

Customize: Ensure that nav menu items can be shift-clicked to edit in secondary instances of the same nav menu.

When the same nav menu is shown multiple times on a page, only the first instance of the nav menu will include id attributes. Subsequent instances will have the id attributes omitted. However, in both cases the underlying nav menu item's post ID is available among the class names, so the post ID can be more reliably obtained from class instead of the id attribute.

Amends [36383].
Fixes #32681.

File:

• trunk/src/wp-includes/js/customize-preview-nav-menus.js (modified) (2 diffs)

trunk/src/wp-includes/js/customize-preview-nav-menus.js

@@ -280 +280 @@
          */
         highlightControls: function() {
-            var selector = '.menu-item[id^=menu-item-]',
+            var selector = '.menu-item',
                 addTooltips;
 
@@ -290 +290 @@
                 }
 
-                navMenuItemParts = $( this ).attr( 'id' ).match( /^menu-item-(\d+)$/ );
+                navMenuItemParts = $( this ).attr( 'class' ).match( /(?:^|\s)menu-item-(\d+)(?:\s|$)/ );
                 if ( navMenuItemParts ) {
                     e.preventDefault();