Changeset 36538 for trunk/tests/phpunit/tests/l10n.php

Timestamp:

02/16/2016 09:14:45 PM (9 years ago)

Author:

ocean90

Message:

i18n: Prevent is_textdomain_loaded() from returning true even if there are no translations for the domain.

In get_translations_for_domain() don't fill the global $l10n with NOOP_Translations instances, return a NOOP_Translations instance instead.

Props nacin, jrf.
Fixes #21319.

File:

• trunk/tests/phpunit/tests/l10n.php (modified) (1 diff)

trunk/tests/phpunit/tests/l10n.php

@@ -27 +27 @@
     }
 
+    /**
+     * @ticket 21319
+     */
+    function test_is_textdomain_loaded_for_no_translations() {
+        $this->assertFalse( load_textdomain( 'wp-tests-domain', DIR_TESTDATA . '/non-existent-file' ) );
+        $this->assertFalse( is_textdomain_loaded( 'wp-tests-domain' ) );
+        $this->assertInstanceOf( 'NOOP_Translations', get_translations_for_domain( 'wp-tests-domain' ) );
+        // Ensure that we don't confuse NOOP_Translations to be a loaded text domain.
+        $this->assertFalse( is_textdomain_loaded( 'wp-tests-domain' ) );
+        $this->assertFalse( unload_textdomain( 'wp-tests-domain' ) );
+    }
+
+    /**
+     * @ticket 21319
+     */
+    function test_is_textdomain_is_not_loaded_after_gettext_call_with_no_translations() {
+        $this->assertFalse( is_textdomain_loaded( 'wp-tests-domain' ) );
+        __( 'just some string', 'wp-tests-domain' );
+        $this->assertFalse( is_textdomain_loaded( 'wp-tests-domain' ) );
+    }
 }