Changeset 36622 for trunk/tests/phpunit/tests/customize/setting.php

Timestamp:

02/23/2016 01:01:43 AM (10 years ago)

Author:

westonruter

Message:

Customize: Prevent dropping backslashes from input on general settings and settings for nav menus and some widgets.

Ensures that intentional backslashes (e.g. "\o/") can be used in:

• Site title
• Site description
• Nav menu name
• Custom Menu widget title
• Tag Cloud widget title
• Text widget body if can't unfiltered_html

The latter three are also fixed on the widgets admin page.

Fixes #35898.

File:

• trunk/tests/phpunit/tests/customize/setting.php (modified) (4 diffs)

trunk/tests/phpunit/tests/customize/setting.php

@@ -68 +68 @@
 
     public $post_data_overrides = array(
-        'unset_option_overridden' => 'unset_option_post_override_value',
-        'unset_theme_mod_overridden' => 'unset_theme_mod_post_override_value',
-        'set_option_overridden' => 'set_option_post_override_value',
-        'set_theme_mod_overridden' => 'set_theme_mod_post_override_value',
-        'unset_option_multi_overridden[foo]' => 'unset_option_multi_overridden[foo]_post_override_value',
-        'unset_theme_mod_multi_overridden[foo]' => 'unset_theme_mod_multi_overridden[foo]_post_override_value',
-        'set_option_multi_overridden[foo]' => 'set_option_multi_overridden[foo]_post_override_value',
-        'set_theme_mod_multi_overridden[foo]' => 'set_theme_mod_multi_overridden[foo]_post_override_value',
+        'unset_option_overridden' => 'unset_option_post_override_value\\o/',
+        'unset_theme_mod_overridden' => 'unset_theme_mod_post_override_value\\o/',
+        'set_option_overridden' => 'set_option_post_override_value\\o/',
+        'set_theme_mod_overridden' => 'set_theme_mod_post_override_value\\o/',
+        'unset_option_multi_overridden[foo]' => 'unset_option_multi_overridden[foo]_post_override_value\\o/',
+        'unset_theme_mod_multi_overridden[foo]' => 'unset_theme_mod_multi_overridden[foo]_post_override_value\\o/',
+        'set_option_multi_overridden[foo]' => 'set_option_multi_overridden[foo]_post_override_value\\o/',
+        'set_theme_mod_multi_overridden[foo]' => 'set_theme_mod_multi_overridden[foo]_post_override_value\\o/',
     );
 
@@ -300 +300 @@
         $type = 'custom_type';
         $post_data_overrides = array(
-            "unset_{$type}_with_post_value" => "unset_{$type}_without_post_value",
-            "set_{$type}_with_post_value" => "set_{$type}_without_post_value",
+            "unset_{$type}_with_post_value" => "unset_{$type}_without_post_value\\o/",
+            "set_{$type}_with_post_value" => "set_{$type}_without_post_value\\o/",
         );
         $_POST['customized'] = wp_slash( wp_json_encode( $post_data_overrides ) );
@@ -418 +418 @@
 
         // Try setting post value without user as admin.
-        $this->manager->set_post_value( $setting->id, 'hello world' );
+        $this->manager->set_post_value( $setting->id, 'hello world \\o/' );
         $this->assertFalse( $setting->save() );
         $this->assertTrue( 0 === did_action( 'customize_update_custom' ) );
@@ -438 +438 @@
      */
     function handle_customize_update_custom_foo_action( $value, $setting = null ) {
-        $this->assertEquals( 'hello world', $value );
+        $this->assertEquals( 'hello world \\o/', $value );
         $this->assertInstanceOf( 'WP_Customize_Setting', $setting );
     }