Changeset 36625 for trunk/src/wp-includes/query.php

Timestamp:

02/23/2016 02:20:28 AM (9 years ago)

Author:

boonebgorges

Message:

Query: is_*( $int ) should not falsely match strings starting with "$int".

Another chapter in the Storied Annals of Weird in_array() Behavior:
in_array( 4, array( "4-cool-dudes" ) ); resolves to true, such that
is_page( 4 ) was returning true for posts with the name '4-cool-dudes'.

We work around this behavior by ensuring that values passed to the is_
methods are cast to strings before the in_array() checks. ID checks still
work as expected; see #24674.

Props mikejolley, swissspidy, boonebgorges.
Fixes #35902.

File:

• trunk/src/wp-includes/query.php (modified) (6 diffs)

trunk/src/wp-includes/query.php

@@ -4203 +4203 @@
         }
 
-        $attachment = (array) $attachment;
+        $attachment = array_map( 'strval', (array) $attachment );
 
         $post_obj = $this->get_queried_object();
@@ -4237 +4237 @@
         $author_obj = $this->get_queried_object();
 
-        $author = (array) $author;
+        $author = array_map( 'strval', (array) $author );
 
         if ( in_array( (string) $author_obj->ID, $author ) )
@@ -4269 +4269 @@
         $cat_obj = $this->get_queried_object();
 
-        $category = (array) $category;
+        $category = array_map( 'strval', (array) $category );
 
         if ( in_array( (string) $cat_obj->term_id, $category ) )
@@ -4301 +4301 @@
         $tag_obj = $this->get_queried_object();
 
-        $tag = (array) $tag;
+        $tag = array_map( 'strval', (array) $tag );
 
         if ( in_array( (string) $tag_obj->term_id, $tag ) )
@@ -4503 +4503 @@
         $page_obj = $this->get_queried_object();
 
-        $page = (array) $page;
+        $page = array_map( 'strval', (array) $page );
 
         if ( in_array( (string) $page_obj->ID, $page ) ) {
@@ -4596 +4596 @@
         $post_obj = $this->get_queried_object();
 
-        $post = (array) $post;
+        $post = array_map( 'strval', (array) $post );
 
         if ( in_array( (string) $post_obj->ID, $post ) ) {