Changeset 36637

Timestamp:

02/23/2016 05:15:23 PM (7 years ago)

Author:

swissspidy

Message:

Embeds: Make the click event handler work for dynamically added links.

Props JamesDiGioia.
Fixes #35630.

File:

• trunk/src/wp-includes/js/wp-embed-template.js (modified) (2 diffs)

trunk/src/wp-includes/js/wp-embed-template.js

@@ -27 +27 @@
             share_input = document.querySelectorAll( '.wp-embed-share-input' ),
             share_dialog_tabs = document.querySelectorAll( '.wp-embed-share-tab-button button' ),
-            links = document.getElementsByTagName( 'a' ),
             i;
 
@@ -155 +154 @@
              * Send link target to the parent (embedding) site.
              */
-            sendEmbedMessage( 'link', href );
-            e.preventDefault();
-        }
-
-        for ( i = 0; i < links.length; i++ ) {
-            links[ i ].addEventListener( 'click', linkClickHandler );
-        }
+            if ( href ) {
+                sendEmbedMessage( 'link', href );
+                e.preventDefault();
+            }
+        }
+
+        document.addEventListener( 'click', linkClickHandler );
     }