Changeset 36638

Timestamp:

02/23/2016 05:19:57 PM (9 years ago)

Author:

swissspidy

Message:

Themes: Improve error messages for broken themes.

Props mayukojpn for initial patch.
Fixes #35286.

Location:

trunk/src

Files:

• wp-admin/network/themes.php (modified) (1 diff)
• wp-admin/themes.php (modified) (1 diff)
• wp-includes/class-wp-theme.php (modified) (1 diff)

trunk/src/wp-admin/network/themes.php

@@ -288 +288 @@
 
 if ( 'broken' == $status )
-    echo '<p class="clear">' . __('The following themes are installed but incomplete. Themes must have a stylesheet and a template.') . '</p>';
+    echo '<p class="clear">' . __( 'The following themes are installed but incomplete.' ) . '</p>';
 ?>
 

trunk/src/wp-admin/themes.php

@@ -296 +296 @@
 <div class="broken-themes">
 <h3><?php _e('Broken Themes'); ?></h3>
-<p><?php _e('The following themes are installed but incomplete. Themes must have a stylesheet and a template.'); ?></p>
+<p><?php _e( 'The following themes are installed but incomplete.' ); ?></p>
 
 <?php

trunk/src/wp-includes/class-wp-theme.php

@@ -269 +269 @@
             $this->template = $this->stylesheet;
             if ( ! file_exists( $this->theme_root . '/' . $this->stylesheet . '/index.php' ) ) {
-                $this->errors = new WP_Error( 'theme_no_index', __( 'Template is missing.' ) );
+                $error_message = sprintf(
+                    /* translators: 1: index.php, 2: Codex URL, 3: style.css */
+                    __( 'Template is missing. Standalone themes need to have a %1$s template file. <a href="%2$s">Child themes</a> need to have a Template header in the %3$s stylesheet.' ),
+                    '<code>index.php</code>',
+                    __( 'https://codex.wordpress.org/Child_Themes' ),
+                    '<code>style.css</code>'
+                );
+                $this->errors = new WP_Error( 'theme_no_index', $error_message );
                 $this->cache_add( 'theme', array( 'headers' => $this->headers, 'errors' => $this->errors, 'stylesheet' => $this->stylesheet, 'template' => $this->template ) );
                 return;