Changeset 36689 for trunk/src/wp-includes/class-wp-customize-nav-menus.php

Timestamp:

02/24/2016 06:27:45 PM (10 years ago)

Author:

westonruter

Message:

Customize: Allow controls to be registered without any associated settings.

• Improves parity between partials and controls. A partial or control can be settingless if instantiated with settings param as empty array (otherwise, if null, then the partial/control ID is used).
• Eliminate need to create dummy settings that serve no purpose except to place a control in the UI.
• Removes dummy settings for create_new_menu and new_menu_name.
• Introduces WP_Customize_Control::$capability and WP_Customize_Partial::$capability, and if set checks them in the respective check_capabilities() methods.
• Prevents PHP fatal error from happening when non-existing settings are provided to control: "Call to a member function check_capabilities() on a non-object".
• Fixes issue where nav menu items and widgets were no longer working with selective refresh because cap check was failing.

See #27355.
Fixes #35926.

File:

• trunk/src/wp-includes/class-wp-customize-nav-menus.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-customize-nav-menus.php

@@ -607 +607 @@
         ) ) );
 
-        $this->manager->add_setting( 'new_menu_name', array(
-            'type'      => 'new_menu',
-            'default'   => '',
-            'transport' => isset( $this->manager->selective_refresh ) ? 'postMessage' : 'refresh',
-        ) );
-
         $this->manager->add_control( 'new_menu_name', array(
             'label'       => '',
             'section'     => 'add_menu',
             'type'        => 'text',
+            'settings'    => array(),
             'input_attrs' => array(
                 'class'       => 'menu-name-field',
@@ -623 +618 @@
         ) );
 
-        $this->manager->add_setting( 'create_new_menu', array(
-            'type' => 'new_menu',
-        ) );
-
         $this->manager->add_control( new WP_Customize_New_Menu_Control( $this->manager, 'create_new_menu', array(
-            'section' => 'add_menu',
+            'section'  => 'add_menu',
+            'settings' => array(),
         ) ) );
     }
@@ -852 +844 @@
                     'render_callback'     => array( $this, 'render_nav_menu_partial' ),
                     'container_inclusive' => true,
+                    'settings'            => array(), // Empty because the nav menu instance may relate to a menu or a location.
+                    'capability'          => 'edit_theme_options',
                 )
             );