Changeset 36708

Timestamp:

02/25/2016 10:22:43 AM (9 years ago)

Author:

swissspidy

Message:

Embeds: Use a more accessible way to initially hide the iframe.

This fixes a bug in Firefox where assets inside the iframe aren't being displayed because they have no computed style.

See #35894.

Location:

trunk

Files:

• src/wp-includes/embed.php (modified) (2 diffs)
• src/wp-includes/js/wp-embed.js (modified) (1 diff)
• tests/phpunit/tests/oembed/filterResult.php (modified) (2 diffs)

trunk/src/wp-includes/embed.php

@@ -778 +778 @@
     if ( ! empty( $content[1] ) ) {
         // We have a blockquote to fall back on. Hide the iframe by default.
-        $html = str_replace( '<iframe', '<iframe style="display:none;"', $html );
+        $html = str_replace( '<iframe', '<iframe style="position: absolute; clip: rect(1px, 1px, 1px, 1px);"', $html );
         $html = str_replace( '<blockquote', '<blockquote class="wp-embedded-content"', $html );
     }
@@ -954 +954 @@
  */
 function _oembed_filter_feed_content( $content ) {
-    return str_replace( '<iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="display:none;"', '<iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted"', $content );
+    return str_replace( '<iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);"', '<iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted"', $content );
 }
 

trunk/src/wp-includes/js/wp-embed.js

@@ -51 +51 @@
             }
 
-            source.style.display = '';
+            source.removeAttribute( 'style' );
 
             /* Resize the iframe on request. */

trunk/tests/phpunit/tests/oembed/filterResult.php

@@ -84 +84 @@
         $actual = wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), '' );
 
-        $this->assertEquals( '<blockquote class="wp-embedded-content"></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="display:none;"></iframe>', $actual );
+        $this->assertEquals( '<blockquote class="wp-embedded-content"></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);"></iframe>', $actual );
     }
 
@@ -91 +91 @@
         $actual = wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), '' );
 
-        $this->assertEquals( '<blockquote class="wp-embedded-content"><a href=""></a></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="display:none;"></iframe>', $actual );
+        $this->assertEquals( '<blockquote class="wp-embedded-content"><a href=""></a></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="position: absolute; clip: rect(1px, 1px, 1px, 1px);"></iframe>', $actual );
     }