Changeset 36721 for trunk/tests/phpunit/tests/rewrite.php

Timestamp:

02/26/2016 02:08:47 AM (9 years ago)

Author:

johnbillion

Message:

Remove (or at least reduce) the need to reset common $_SERVER variables before assertions or between tests, by introducing a method which automatically resets them during test setup.

See #35954

File:

• trunk/tests/phpunit/tests/rewrite.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rewrite.php

@@ -104 +104 @@
 
     function test_url_to_postid_set_url_scheme_http_to_https() {
-        // Save server data for cleanup
-        $is_ssl = is_ssl();
-
         $_SERVER['HTTPS'] = 'on';
 
@@ -116 +113 @@
         $page_permalink = get_permalink( $page_id );
         $page_url_to_id = url_to_postid( set_url_scheme( $page_permalink, 'http' ) );
-
-        // Cleanup.
-        $_SERVER['HTTPS'] = $is_ssl ? 'on' : 'off';
 
         $this->assertEquals( $post_id, $post_url_to_id );