Changeset 36779

Timestamp:

02/29/2016 08:34:48 PM (9 years ago)

Author:

boonebgorges

Message:

Put an assertion in test_nonexistent_array() test.

The point of the test is to demonstrate that PHP doesn't throw a notice when
calling unset() on an undefined array key. To placate PHPUnit's useless test
detection, we add a redundant assertion.

Introduced in [25240].

See #36016.

File:

• trunk/tests/phpunit/tests/basic.php (modified) (2 diffs)

trunk/tests/phpunit/tests/basic.php

@@ -92 +92 @@
     }
 
+    /**
+     * @ticket 17884
+     */
     function test_setting_nonexistent_arrays() {
         $page = 1;
@@ -98 +101 @@
         $empty_array[$page][$field] = 'foo';
 
+        // Assertion not strictly needed; we mainly want to show that a notice is not thrown.
         unset( $empty_array[$page]['bar']['baz'] );
+        $this->assertFalse( isset( $empty_array[ $page ]['bar']['baz'] ) );
     }