Changeset 36784

Timestamp:

02/29/2016 09:53:18 PM (9 years ago)

Author:

boonebgorges

Message:

More specific test for a bad callback in WP_Customize_Partial test.

The 'render_callback' passed to WP_Customize_Partial must either echo or
return a result - not both. When it's detected that the callback echoes and
returns a value, the return value takes precedence. This is now reflected in
the corresponding unit test.

Introduced in [36586].

See #27355. See #36016.

File:

• trunk/tests/phpunit/tests/customize/partial.php (modified) (1 diff)

trunk/tests/phpunit/tests/customize/partial.php

@@ -216 +216 @@
      * @see WP_Customize_Partial::render()
      */
-    function test_render_bad_callback() {
+    function test_render_with_bad_callback_should_give_preference_to_return_value() {
         $partial = new WP_Customize_Partial( $this->selective_refresh, 'foo', array(
             'render_callback' => array( $this, 'render_echo_and_return' ),
         ) );
         $this->setExpectedIncorrectUsage( 'render' );
-        $partial->render();
+        $this->assertSame( 'bar', $partial->render() );
     }