Changeset 36785

Timestamp:

02/29/2016 09:55:41 PM (9 years ago)

Author:

boonebgorges

Message:

Tests: setExpectedDeprecated and setExpectedIncorrectUsage tests should make assertions.

Introduced in [31306].

See #36016.

File:

• trunk/tests/phpunit/tests/includes/helpers.php (modified) (3 diffs)

trunk/tests/phpunit/tests/includes/helpers.php

@@ -175 +175 @@
     public function test_setExpectedDeprecated() {
         $this->setExpectedDeprecated( 'Tests_TestHelpers::mock_deprecated' );
-        $this->mock_deprecated();
+        $this->assertTrue( $this->mock_deprecated() );
     }
 
@@ -183 +183 @@
     public function test_setExpectedIncorrectUsage() {
         $this->setExpectedIncorrectUsage( 'Tests_TestHelpers::mock_incorrect_usage' );
-        $this->mock_incorrect_usage();
+        $this->assertTrue( $this->mock_incorrect_usage() );
     }
 
@@ -198 +198 @@
     protected function mock_deprecated() {
         _deprecated_function( __METHOD__, '2.5' );
+        return true;
     }
 
     protected function mock_incorrect_usage() {
         _doing_it_wrong( __METHOD__, __( 'Incorrect usage test' ), '2.5' );
+        return true;
     }
 }