Changeset 3684

Timestamp:

04/04/2006 12:16:27 AM (20 years ago)

Author:

ryan

Message:

List manip improvements from mdawaffe. fixes #2633

Location:

trunk/wp-admin

Files:

• cat-js.php (modified) (1 diff)
• categories.js (modified) (1 diff)
• categories.php (modified) (3 diffs)
• custom-fields.js (modified) (2 diffs)
• edit-link-form.php (modified) (1 diff)
• list-manipulation-js.php (modified) (4 diffs)
• users.js (modified) (1 diff)
• wp-admin.css (modified) (2 diffs)

trunk/wp-admin/cat-js.php

@@ -3 +3 @@
 header('Content-type: text/javascript; charset=' . get_settings('blog_charset'), true);
 ?>
-addLoadEvent(function(){catList=new listMan('categorychecklist');catList.ajaxRespEl='jaxcat';catList.clearInputs.push('newcat');catList.topAdder=1;catList.alt=0});
+addLoadEvent(function(){catList=new listMan('categorychecklist');catList.ajaxRespEl='jaxcat';catList.topAdder=1;catList.alt=0;catList.showLink=0;});
 addLoadEvent(newCatAddIn);
 function newCatAddIn() {

trunk/wp-admin/categories.js

@@ -3 +3 @@
     if (!theList.theList) return false;
     document.forms.addcat.submit.onclick = function(e) {return killSubmit('theList.ajaxAdder("cat", "addcat");', e); };
-    theList.clearInputs.push('cat_name','category_parent','category_description');
 }

trunk/wp-admin/categories.php

@@ -148 +148 @@
 </table>
 
-<div id="ajax-response"></div>
-
 </div>
 
@@ -160 +158 @@
     <h2><?php _e('Add New Category') ?></h2>
     <form name="addcat" id="addcat" action="categories.php" method="post">
-        
-        <p><?php _e('Name:') ?><br />
+        <div class="alignleft"><?php _e('Name:') ?><br />
         <input type="text" name="cat_name" id="cat_name" value="" /></p>
         <p><?php _e('Category parent:') ?><br />
@@ -167 +164 @@
         <option value='0'><?php _e('None') ?></option>
         <?php wp_dropdown_cats(0); ?>
-        </select></p>
+        </select>
+    </div>
+    <div id="ajax-response" class="alignleft"></div>
+    <br class="clear" />
         <p><?php _e('Description: (optional)') ?> <br />
         <textarea name="category_description" id="category_description" rows="5" cols="50" style="width: 97%;"></textarea></p>

trunk/wp-admin/custom-fields.js

@@ -1 +1 @@
 addLoadEvent(customFieldsAddIn);
 function customFieldsAddIn() {
+    theList.showLink=0;
     if (!theList.theList) return false;
     inputs = theList.theList.getElementsByTagName('input');
@@ -15 +16 @@
     document.getElementById('metakeyinput').onkeypress = function(e) {return killSubmit('theList.inputData+="&id="+document.getElementById("post_ID").value;theList.ajaxAdder("meta", "newmeta", customFieldsOnComplete);', e); };
     document.getElementById('updatemetasub').onclick = function(e) {return killSubmit('theList.inputData+="&id="+document.getElementById("post_ID").value;theList.ajaxAdder("meta", "newmeta", customFieldsOnComplete);', e); };
-    theList.clearInputs.push('metakeyselect','metakeyinput','metavalue');
 }
 function customFieldsOnComplete() {

trunk/wp-admin/edit-link-form.php

@@ -41 +41 @@
 <div class="dbx-content">
 <p id="jaxcat"></p>
-<div id="categorychecklist"><?php dropdown_categories(get_settings('default_link_category')); ?></div></div>
+<ul id="categorychecklist"><?php dropdown_categories(get_settings('default_link_category')); ?></ul>
+</div>
 </fieldset>
 

trunk/wp-admin/list-manipulation-js.php

@@ -8 +8 @@
 
 function WPAjax(file, responseEl){//class WPAjax extends sack
-    this.getResponseElement=function(r){var p=document.getElementById(r+'-p');if(!p){p=document.createElement('span');p.id=r+'ajax-response-p';document.getElementById(r).appendChild(p);}this.myResponseElement=p; }
+    this.getResponseElement=function(r){var p=document.getElementById(r+'-p');if(!p){p=document.createElement('span');p.id=r+'-p';document.getElementById(r).appendChild(p);}this.myResponseElement=p;  }
     this.parseAjaxResponse=function(){
-        if(isNaN(this.response)){this.myResponseElement.innerHTML='<div class="error">'+this.response+'</div>';return false;}
+        if(isNaN(this.response)){this.myResponseElement.innerHTML='<div class="error"><p>'+this.response+'</p></div>';return false;}
         this.response=parseInt(this.response,10);
-        if(-1==this.response){this.myResponseElement.innerHTML="<?php _e("You don't have permission to do that."); ?>";return false;}
-        else if(0==this.response){this.myResponseElement.innerHTML="<?php _e("Something odd happened. Try refreshing the page? Either that or what you tried to change never existed in the first place."); ?>";return false;}
+        if(-1==this.response){this.myResponseElement.innerHTML="<div class='error'><p><?php _e("You don't have permission to do that."); ?></p></div>";return false;}
+        else if(0==this.response){this.myResponseElement.innerHTML="<div class='error'><p><?php _e("Something odd happened. Try refreshing the page? Either that or what you tried to change never existed in the first place."); ?></p></div>";return false;}
         return true;
     }
     this.parseAjaxResponseXML=function(){
         if(this.responseXML&&typeof this.responseXML=='object')return true;
-        if(isNaN(this.response)){this.myResponseElement.innerHTML='<div class="error">'+this.response+'</div>';return false;}
+        if(isNaN(this.response)){this.myResponseElement.innerHTML='<div class="error"><p>'+this.response+'</p></div>';return false;}
         var r=parseInt(this.response,10);
-        if(-1==r){this.myResponseElement.innerHTML="<?php _e("You don't have permission to do that."); ?>";}
-        else if(0==r){this.myResponseElement.innerHTML="<?php _e("Invalid Entry."); ?>";}
+        if(-1==r){this.myResponseElement.innerHTML="<div class='error'><p><?php _e("You don't have permission to do that."); ?></p></div>";}
+        else if(0==r){this.myResponseElement.innerHTML="<div class='error'><p><?php _e("Invalid Entry."); ?></p></div>";}
         return false;
     }
@@ -37 +37 @@
     this.theList=null;
     this.ajaxRespEl=null;
-    this.inputData='';this.clearInputs=new Array();
+    this.inputData='';this.clearInputs=new Array();this.showLink=1;
     this.topAdder=0;this.alt='alternate';this.recolorPos;this.reg_color='#FFFFFF';this.alt_color='#F1F1F1';
     var listType;var listItems;
@@ -58 +58 @@
                 else tempObj.addListItem(getNodeValue(newItems[c],'newitem'),newItems.length);
             }}
-            this.myResponseElement.innerHTML='';tempObj.inputData='';
+            tempObj.inputData='';
+            if(tempObj.showLink){this.myResponseElement.innerHTML='<div id="jumplink" class="updated fade"><p><a href="#'+what+'-'+id+'"><?php _e('Jump to new item'); ?></a></p></div>';}
+            else this.myResponseElement.innerHTML='';
             for(var i=0;i<tempObj.clearInputs.length;i++){try{var theI=document.getElementById(tempObj.clearInputs[i]);if(theI.tagName.match(/select/i))theI.selectedIndex=0;else theI.value='';}catch(e){}}
             if(onComplete&&typeof onComplete=='function')onComplete();
-            tempObj.recolorList(tempObj.recolorPos,1000)
+            tempObj.recolorList(tempObj.recolorPos,1000);
         }
         this.ajaxAdd.runAJAX('action='+(update?'update-':'add-')+what+this.inputData);
@@ -124 +126 @@
                 if('action'==inputs[a][i].name)continue;
                 if('text'==inputs[a][i].type||'password'==inputs[a][i].type||'hidden'==inputs[a][i].type||inputs[a][i].tagName.match(/textarea/i)){
-                    this.inputData+='&'+inputs[a][i].name+'='+encodeURIComponent(inputs[a][i].value);
+                    this.inputData+='&'+inputs[a][i].name+'='+encodeURIComponent(inputs[a][i].value);if('hidden'!=inputs[a][i].type)this.clearInputs.push(inputs[a][i].id);
                 }else if(inputs[a][i].tagName.match(/select/i)){
-                    this.inputData+='&'+inputs[a][i].name+'='+encodeURIComponent(inputs[a][i].options[inputs[a][i].selectedIndex].value);
+                    this.inputData+='&'+inputs[a][i].name+'='+encodeURIComponent(inputs[a][i].options[inputs[a][i].selectedIndex].value);this.clearInputs.push(inputs[a][i].id);
                 }
             }   

trunk/wp-admin/users.js

@@ -17 +17 @@
     var role = roleEl.options[roleEl.selectedIndex].value;
     if ( !theUserLists['role-' + role] ) return true;
-    theUserLists['role-' + role].clearInputs.push('user_login', 'first_name', 'last_name', 'email', 'url', 'pass1', 'pass2', 'role');
     return theUserLists['role-' + role].ajaxAdder('user', 'adduser');
 }

trunk/wp-admin/wp-admin.css

@@ -628 +628 @@
 }
 
-#templateside h3, #postcustom p {
+#templateside h3, #postcustom p.submit {
     margin: 0;
 }
@@ -969 +969 @@
     padding: 0;
 }
+#ajax-response.alignleft {
+    margin-left: 2em;
+}