Changeset 36873

Timestamp:

03/07/2016 09:59:02 AM (9 years ago)

Author:

swissspidy

Message:

Embeds: Adjust the iframe title attribute for improved accessibility.

Changes the title attribute from Embedded WordPress Post to "Post name" — site title.

Props ramiy.
Fixes #35804.

Location:

trunk

Files:

• src/wp-includes/embed.php (modified) (1 diff)
• tests/phpunit/tests/oembed/template.php (modified) (1 diff)

trunk/src/wp-includes/embed.php

@@ -491 +491 @@
         absint( $width ),
         absint( $height ),
-        esc_attr__( 'Embedded WordPress Post' )
+        esc_attr(
+            sprintf(
+                /* translators: 1: post title, 2: site name */
+                __( '“%1$s” — %2$s' ),
+                get_the_title( $post ),
+                get_bloginfo( 'name' )
+            )
+        )
     );
 

trunk/tests/phpunit/tests/oembed/template.php

@@ -243 +243 @@
     function test_get_post_embed_html() {
         $post_id = self::factory()->post->create();
-
-        $expected = '<iframe sandbox="allow-scripts" security="restricted" src="' . esc_url( get_post_embed_url( $post_id ) ) . '" width="200" height="200" title="Embedded WordPress Post" frameborder="0" marginwidth="0" marginheight="0" scrolling="no" class="wp-embedded-content"></iframe>';
+        $title = esc_attr(
+            sprintf(
+                __( '&#8220;%1$s&#8221; &#8212; %2$s' ),
+                get_the_title( $post_id ),
+                get_bloginfo( 'name' )
+            )
+        );
+
+        $expected = '<iframe sandbox="allow-scripts" security="restricted" src="' . esc_url( get_post_embed_url( $post_id ) ) . '" width="200" height="200" title="' . $title . '" frameborder="0" marginwidth="0" marginheight="0" scrolling="no" class="wp-embedded-content"></iframe>';
 
         $this->assertStringEndsWith( $expected, get_post_embed_html( 200, 200, $post_id ) );