Changeset 36885

Timestamp:

03/08/2016 04:44:25 PM (9 years ago)

Author:

ocean90

Message:

Tests: Remove test_new_files_are_not_in_old_files_array() from [36843].

The test assumes that if a CSS file was added to $_old_files all three files (.css, .min.css, -rtl.min.css; it's actually missing the fourth case, -rtl.css) don't exist anymore. But this isn't always the case. The test is also incredible slow because it does three file_exists() checks for each file — the global contains 646 files currently.

It's important what we have in the /build directory and that's covered by test_new_files_are_not_in_old_files_array_compiled().

Fixes #36083.

File:

• trunk/tests/phpunit/tests/admin/includesUpdateCore.php (modified) (1 diff)

trunk/tests/phpunit/tests/admin/includesUpdateCore.php

@@ -21 +21 @@
 
     /**
-     * Ensure no project files are inside `$_old_files`.
+     * Ensure no project files are inside `$_old_files` in the build directory.
      *
      * @ticket 36083
      *
-     * @dataProvider data_old_files
-     *
-     * @param string $file File name.
-     */
-    public function test_new_files_are_not_in_old_files_array( $file ) {
-        $this->assertFalse( file_exists( ABSPATH . $file ) );
-        $this->assertFalse( file_exists( ABSPATH . str_replace( '.min.', '.', $file ) ) );
-        $this->assertFalse( file_exists( ABSPATH . str_replace( '-rtl.min.', '.', $file ) ) );
-    }
-
-    /**
-     * Ensure no project files are inside `$_old_files` in the build directory.
-     *
-     * The previous test confirms that no existing files are inside `$_old_files`.
-     * However, we must also confirm that these do not exist in the final build.
-     *
-     * @ticket 36083
-     *
-     * @depends test_new_files_are_not_in_old_files_array
      * @dataProvider data_old_files
      *