Changeset 36889 for trunk/tests/phpunit/tests/customize/nav-menus.php

Timestamp:

03/09/2016 12:08:51 AM (9 years ago)

Author:

westonruter

Message:

Customize: Fix regressions and harden implementation of selective refresh for nav menus.

• Request full refresh if there are nav menu instances that lack partials for a changed setting.
• Restore WP_Customize_Nav_Menus::$preview_nav_menu_instance_args and WP_Customize_Nav_Menus::export_preview_data() from 4.3, and keeping a tally of all wp_nav_menu() calls regardless of whether they can use selective refresh.
• Ensure that all instances of wp_nav_menu() are tallied, regardless of whether they are made during the initial preview call or during subsequent partial renderings. Export nav_menu_instance_args with each partial rendering response just as they are returned when rendering the preview as a whole.
• Fix issues with Custom Menu widget where nav menu items would fail to render when switching between menus when a menu lacked items to begin with.
• Make sure the fallback behavior is invoked when the partial is no longer associated with a menu.
• Do fallback behavior to refresh preview when all menu items are removed from a menu.

Follows [36586].
See #27355.
Fixes #35362.

File:

• trunk/tests/phpunit/tests/customize/nav-menus.php (modified) (5 diffs)

trunk/tests/phpunit/tests/customize/nav-menus.php

@@ -618 +618 @@
         do_action( 'customize_register', $this->wp_customize );
         $menus = $this->wp_customize->nav_menus;
+        $menu_id = wp_create_nav_menu( 'Foo' );
 
         $results = $menus->filter_wp_nav_menu_args( array(
@@ -623 +624 @@
             'fallback_cb'     => 'wp_page_menu',
             'walker'          => '',
-            'menu'            => wp_create_nav_menu( 'Foo' ),
+            'menu'            => $menu_id,
             'items_wrap'      => '<ul id="%1$s" class="%2$s">%3$s</ul>',
         ) );
         $this->assertArrayHasKey( 'customize_preview_nav_menus_args', $results );
+        $this->assertTrue( $results['can_partial_refresh'] );
 
         $results = $menus->filter_wp_nav_menu_args( array(
@@ -634 +636 @@
             'items_wrap'      => '<ul id="%1$s" class="%2$s">%3$s</ul>',
         ) );
-        $this->assertArrayNotHasKey( 'customize_preview_nav_menus_args', $results );
+        $this->assertFalse( $results['can_partial_refresh'] );
+        $this->assertArrayHasKey( 'customize_preview_nav_menus_args', $results );
         $this->assertEquals( 'wp_page_menu', $results['fallback_cb'] );
 
@@ -645 +648 @@
             'items_wrap'      => '<ul id="%1$s" class="%2$s">%3$s</ul>',
         ) );
+        $this->assertTrue( $results['can_partial_refresh'] );
         $this->assertArrayHasKey( 'customize_preview_nav_menus_args', $results );
         $this->assertEquals( $nav_menu_term->term_id, $results['customize_preview_nav_menus_args']['menu'] );
+
+        $results = $menus->filter_wp_nav_menu_args( array(
+            'echo'            => true,
+            'fallback_cb'     => 'wp_page_menu',
+            'walker'          => '',
+            'menu'            => $menu_id,
+            'container'       => 'div',
+            'items_wrap'      => '%3$s',
+        ) );
+        $this->assertTrue( $results['can_partial_refresh'] );
+
+        $results = $menus->filter_wp_nav_menu_args( array(
+            'echo'            => true,
+            'fallback_cb'     => 'wp_page_menu',
+            'walker'          => '',
+            'menu'            => $menu_id,
+            'container'       => false,
+            'items_wrap'      => '<ul id="%1$s" class="%2$s">%3$s</ul>',
+        ) );
+        $this->assertTrue( $results['can_partial_refresh'] );
+
+        $results = $menus->filter_wp_nav_menu_args( array(
+            'echo'            => true,
+            'fallback_cb'     => 'wp_page_menu',
+            'walker'          => '',
+            'menu'            => $menu_id,
+            'container'       => false,
+            'items_wrap'      => '%3$s',
+        ) );
+        $this->assertFalse( $results['can_partial_refresh'] );
     }
 
@@ -692 +726 @@
 
     /**
+     * Test WP_Customize_Nav_Menus::export_preview_data() method.
+     *
+     * @see WP_Customize_Nav_Menus::export_preview_data()
+     */
+    function test_export_preview_data() {
+        ob_start();
+        $this->wp_customize->nav_menus->export_preview_data();
+        $html = ob_get_clean();
+        $this->assertTrue( (bool) preg_match( '/_wpCustomizePreviewNavMenusExports = ({.+})/s', $html, $matches ) );
+        $exported_data = json_decode( $matches[1], true );
+        $this->assertArrayHasKey( 'navMenuInstanceArgs', $exported_data );
+    }
+
+    /**
      * Test WP_Customize_Nav_Menus::render_nav_menu_partial() method.
      *