Changeset 36964 for trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

Timestamp:

03/10/2016 10:36:25 PM (10 years ago)

Author:

afercia

Message:

Accessibility: Improve accessibility for the Plugin details modal.

The plugin details modal can be invoked from several screens. There's now a new
.open-plugin-details-modal CSS class to be used in combination with the
.thickbox CSS class that adds everything needed for accessibility.

• Adds an ARIA role dialog and an aria-label attribute to the modal
• Adds a title attribute to the iframe inside the modal
• Constrains tabbing within the modal
• Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.

File:

• trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -477 +477 @@
 
             /* translators: 1: Plugin name and version. */
-            $action_links[] = '<a href="' . esc_url( $details_link ) . '" class="thickbox" aria-label="' . esc_attr( sprintf( __( 'More information about %s' ), $name ) ) . '" data-title="' . esc_attr( $name ) . '">' . __( 'More Details' ) . '</a>';
+            $action_links[] = '<a href="' . esc_url( $details_link ) . '" class="thickbox open-plugin-details-modal" aria-label="' . esc_attr( sprintf( __( 'More information about %s' ), $name ) ) . '" data-title="' . esc_attr( $name ) . '">' . __( 'More Details' ) . '</a>';
 
             if ( !empty( $plugin['icons']['svg'] ) ) {
@@ -505 +505 @@
                 <div class="name column-name">
                     <h3>
-                        <a href="<?php echo esc_url( $details_link ); ?>" class="thickbox">
+                        <a href="<?php echo esc_url( $details_link ); ?>" class="thickbox open-plugin-details-modal">
                         <?php echo $title; ?>
                         <img src="<?php echo esc_attr( $plugin_icon_url ) ?>" class="plugin-icon" alt="">