Changeset 36964 for trunk/src/wp-admin/update-core.php

Timestamp:

03/10/2016 10:36:25 PM (10 years ago)

Author:

afercia

Message:

Accessibility: Improve accessibility for the Plugin details modal.

The plugin details modal can be invoked from several screens. There's now a new
.open-plugin-details-modal CSS class to be used in combination with the
.thickbox CSS class that adds everything needed for accessibility.

• Adds an ARIA role dialog and an aria-label attribute to the modal
• Adds a title attribute to the iframe inside the modal
• Constrains tabbing within the modal
• Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.

File:

• trunk/src/wp-admin/update-core.php (modified) (1 diff)

trunk/src/wp-admin/update-core.php

@@ -285 +285 @@
         /* translators: 1: Plugin name 2: Plugin version */
         $details_text = sprintf( __( 'View %1$s version %2$s details.' ), $details_name, $plugin_data->update->new_version );
-        $details = sprintf( '<a href="%1$s" class="thickbox">%2$s</a>', esc_url( $details_url ), $details_text );
+        $details = sprintf( '<a href="%1$s" class="thickbox open-plugin-details-modal">%2$s</a>', esc_url( $details_url ), $details_text );
         $checkbox_id =  "checkbox_" . md5( $plugin_data->Name );
         ?>