WordPress.org

Make WordPress Core


Ignore:
Timestamp:
03/10/2016 10:36:25 PM (3 years ago)
Author:
afercia
Message:

Accessibility: Improve accessibility for the Plugin details modal.

The plugin details modal can be invoked from several screens. There's now a new
.open-plugin-details-modal CSS class to be used in combination with the
.thickbox CSS class that adds everything needed for accessibility.

  • Adds an ARIA role dialog and an aria-label attribute to the modal
  • Adds a title attribute to the iframe inside the modal
  • Constrains tabbing within the modal
  • Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/script-loader.php

    r36884 r36964  
    581581        ) );
    582582
    583         $scripts->add( 'plugin-install', "/wp-admin/js/plugin-install$suffix.js", array( 'jquery', 'thickbox' ), false, 1 );
     583        $scripts->add( 'plugin-install', "/wp-admin/js/plugin-install$suffix.js", array( 'jquery', 'jquery-ui-core', 'thickbox' ), false, 1 );
    584584        did_action( 'init' ) && $scripts->localize( 'plugin-install', 'plugininstallL10n', array(
    585             'plugin_information' => __('Plugin Information:'),
     585            'plugin_information' => __( 'Plugin:' ),
     586            'plugin_modal_label' => __( 'Plugin details' ),
    586587            'ays' => __('Are you sure you want to install this plugin?')
    587588        ) );
Note: See TracChangeset for help on using the changeset viewer.