Changeset 36986

Timestamp:

03/14/2016 01:51:12 AM (7 years ago)

Author:

boonebgorges

Message:

Fix test related to cap check in get_edit_term_link().

The test was introduced in [36646] was intended to demonstrate that the cap
check in get_edit_term_link() uses the custom capability from the correct
taxonomy when $taxonomy is not specified but must be inferred from the
provided term. However, the test was wrongly written in pretty much every way.
Antiprops boonebgorges.

Props swissspidy.
See #35922.

File:

• trunk/tests/phpunit/tests/term/getEditTermLink.php (modified) (2 diffs)

trunk/tests/phpunit/tests/term/getEditTermLink.php

@@ -69 +69 @@
     public function test_cap_check_should_use_correct_taxonomy_when_taxonomy_is_not_specified() {
         register_taxonomy( 'wptests_tax_subscriber', 'post', array(
-            'manage_terms' => 'read',
+            'capabilities' => array(
+                'edit_terms' => 'read',
+            ),
         ) );
 
         $t = self::factory()->term->create( array(
-            'taxonomy' => 'wptests_tax',
+            'taxonomy' => 'wptests_tax_subscriber',
             'name' => 'foo',
         ) );
@@ -83 +85 @@
 
         $actual = get_edit_term_link( $t );
-        $this->assertNull( $actual );
+        $this->assertNotNull( $actual );
     }
 }