Changeset 36991 for trunk/src/wp-includes/class-wp-editor.php

Timestamp:

03/14/2016 08:54:58 PM (11 years ago)

Author:

azaozz

Message:

wpLink: fix accessibility issues:

• Add role=dialog and an aria-labelledby attribute to the modal container.
• Change the modal title to h1.
• Remove one   that gets read out as blank by screen readers.
• Replace the Cancel link with a button.
• Clean up unused CSS.

Props afercia.
Fixes #30468.

File:

• trunk/src/wp-includes/class-wp-editor.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-editor.php

@@ -1404 +1404 @@
                 ?>
                 <div id="wp-link-backdrop" style="display: none"></div>
-                <div id="wp-link-wrap" class="wp-core-ui" style="display: none">
+                <div id="wp-link-wrap" class="wp-core-ui" style="display: none" role="dialog" aria-labelledby="link-modal-title">
                 <form id="wp-link" tabindex="-1">
                 <?php wp_nonce_field( 'internal-linking', '_ajax_linking_nonce', false ); ?>
-                <div id="link-modal-title">
-                        <?php _e( 'Insert/edit link' ) ?>
-                        <button type="button" id="wp-link-close"><span class="screen-reader-text"><?php _e( 'Close' ); ?></span></button>
-                </div>
+                <h1 id="link-modal-title"><?php _e( 'Insert/edit link' ) ?></h1>
+                <button type="button" id="wp-link-close"><span class="screen-reader-text"><?php _e( 'Close' ); ?></span></button>
                 <div id="link-selector">
                         <div id="link-options">
@@ -1422 +1420 @@
                                 </div>
                                 <div class="link-target">
-                                        <label><span>&nbsp;</span>
+                                        <label><span></span>
                                         <input type="checkbox" id="wp-link-target" /> <?php _e( 'Open link in a new tab' ); ?></label>
                                 </div>
@@ -1429 +1427 @@
                 <div class="submitbox">
                         <div id="wp-link-cancel">
-                                <a class="submitdelete deletion" href="#"><?php _e( 'Cancel' ); ?></a>
+                                <button type="button" class="button"><?php _e( 'Cancel' ); ?></button>
                         </div>
                         <div id="wp-link-update">