Changeset 36999

Timestamp:

03/15/2016 09:32:15 PM (9 years ago)

Author:

karmatosed

Message:

Twenty Thirteen, Twenty Fourteen and Twenty Fifteen: Fixes insufficient check for existence of DOM elements in jQuery object
Fixes #34033
Props: tywayne

Location:

trunk/src/wp-content/themes

Files:

• twentyfifteen/js/functions.js (modified) (2 diffs)
• twentyfourteen/js/functions.js (modified) (1 diff)
• twentythirteen/js/functions.js (modified) (1 diff)

trunk/src/wp-content/themes/twentyfifteen/js/functions.js

@@ -50 +50 @@
     ( function() {
         var menu, widgets, social;
-        if ( ! secondary || ! button ) {
+        if ( ! secondary.length || ! button.length ) {
             return;
         }
@@ -58 +58 @@
         widgets = secondary.find( '#widget-area' );
         social  = secondary.find( '#social-navigation' );
-        if ( ! widgets.length && ! social.length && ( ! menu || ! menu.children().length ) ) {
+        if ( ! widgets.length && ! social.length && ( ! menu.length || ! menu.children().length ) ) {
             button.hide();
             return;

trunk/src/wp-content/themes/twentyfourteen/js/functions.js

@@ -17 +17 @@
     // Enable menu toggle for small screens.
     ( function() {
-        if ( ! nav || ! button ) {
+        if ( ! nav.length || ! button.length ) {
             return;
         }
 
         // Hide button if menu is missing or empty.
-        if ( ! menu || ! menu.children().length ) {
+        if ( ! menu.length || ! menu.children().length ) {
             button.hide();
             return;

trunk/src/wp-content/themes/twentythirteen/js/functions.js

@@ -35 +35 @@
      */
     ( function() {
-        if ( ! nav || ! button ) {
+        if ( ! nav.length || ! button.length ) {
             return;
         }
 
         // Hide button if menu is missing or empty.
-        if ( ! menu || ! menu.children().length ) {
+        if ( ! menu.length || ! menu.children().length ) {
             button.hide();
             return;