Changeset 37043

Timestamp:

03/22/2016 03:09:05 PM (9 years ago)

Author:

rachelbaker

Message:

XMLRPC: Fix bug where draft posts couldn’t be published in the future, and would publish immediately.

Resolves bug introduced in [r34572], in which editing a Post via the XMLRPC API with a draft post_status, where the post_status changes from draft->publish with a future post_date set for the publish action, will have the future post_date disregarded and the Post will be published immediately. The expected behavior is that the post_date is used to schedule the Post to be published in the future.

Fixes #35874.

Props redsweater, rachelbaker, DrewAPicture

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -1365 +1365 @@
         }
 
+        // Default to not flagging the post date to be edited unless it's intentional.
+        $post_data['edit_date'] = false;
+
         if ( ! empty( $dateCreated ) ) {
             $post_data['post_date'] = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
             $post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' );
+
+            // Flag the post date to be edited.
+            $post_data['edit_date'] = true;
         }
 
@@ -5376 +5382 @@
             $dateCreated = $content_struct['dateCreated']->getIso();
 
+        // Default to not flagging the post date to be edited unless it's intentional.
+        $edit_date = false;
+
         if ( !empty( $dateCreated ) ) {
             $post_date = get_date_from_gmt(iso8601_to_datetime($dateCreated));
             $post_date_gmt = iso8601_to_datetime($dateCreated, 'GMT');
+
+            // Flag the post date to be edited.
+            $edit_date = true;
         } else {
             $post_date     = $postdata['post_date'];
@@ -5385 +5397 @@
 
         // We've got all the data -- post it.
-        $newpost = compact('ID', 'post_content', 'post_title', 'post_category', 'post_status', 'post_excerpt', 'comment_status', 'ping_status', 'post_date', 'post_date_gmt', 'to_ping', 'post_name', 'post_password', 'post_parent', 'menu_order', 'post_author', 'tags_input', 'page_template');
+        $newpost = compact('ID', 'post_content', 'post_title', 'post_category', 'post_status', 'post_excerpt', 'comment_status', 'ping_status', 'edit_date', 'post_date', 'post_date_gmt', 'to_ping', 'post_name', 'post_password', 'post_parent', 'menu_order', 'post_author', 'tags_input', 'page_template');
 
         $result = wp_update_post($newpost, true);