Changeset 37152 for trunk

Timestamp:

03/30/2016 09:40:43 PM (10 years ago)

Author:

westonruter

Message:

Customize: Put focus on change button instead of remove button in media control.

Allow controls to specify the primary element to receive focus by adding a control-focus class.

Props adamsilverstein, westonruter.
Fixes #36337.

Location:

trunk/src

Files:

• wp-admin/js/customize-controls.js (modified) (2 diffs)
• wp-includes/customize/class-wp-customize-media-control.php (modified) (1 diff)

trunk/src/wp-admin/js/customize-controls.js

@@ -78 +78 @@
          */
         focus = function ( params ) {
-                var construct, completeCallback, focus;
+                var construct, completeCallback, focus, focusElement;
                 construct = this;
                 params = params || {};
@@ -91 +91 @@
                         }
 
-                        // Note that we can't use :focusable due to a jQuery UI issue. See: https://github.com/jquery/jquery-ui/pull/1583
-                        focusContainer.find( 'input, select, textarea, button, object, a[href], [tabindex]' ).filter( ':visible' ).first().focus();
+                        focusElement = focusContainer.find( '.control-focus:first' );
+                        if ( 0 === focusElement.length ) {
+                                // Note that we can't use :focusable due to a jQuery UI issue. See: https://github.com/jquery/jquery-ui/pull/1583
+                                focusElement = focusContainer.find( 'input, select, textarea, button, object, a[href], [tabindex]' ).filter( ':visible' ).first();
+                        }
+                        focusElement.focus();
                 };
                 if ( params.completeCallback ) {

trunk/src/wp-includes/customize/class-wp-customize-media-control.php

@@ -197 +197 @@
                                 <# if ( data.canUpload ) { #>
                                 <button type="button" class="button remove-button">{{ data.button_labels.remove }}</button>
-                                <button type="button" class="button upload-button" id="{{ data.settings['default'] }}-button">{{ data.button_labels.change }}</button>
+                                <button type="button" class="button upload-button control-focus" id="{{ data.settings['default'] }}-button">{{ data.button_labels.change }}</button>
                                 <div style="clear:both"></div>
                                 <# } #>