Changeset 37153

Timestamp:

03/30/2016 09:54:45 PM (9 years ago)

Author:

westonruter

Message:

Customize: Fix toggle of title attribute field visibility on nav menus admin page.

Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].

See #35273.
Props sidati, westonruter.
Fixes #36353.

Location:

trunk/src

Files:

• wp-admin/css/customize-nav-menus.css (modified) (2 diffs)
• wp-admin/includes/class-walker-nav-menu-edit.php (modified) (1 diff)
• wp-admin/includes/nav-menu.php (modified) (1 diff)
• wp-includes/customize/class-wp-customize-nav-menu-item-control.php (modified) (1 diff)

trunk/src/wp-admin/css/customize-nav-menus.css

@@ -272 +272 @@
 
 #accordion-panel-nav_menus .field-link-target,
-#accordion-panel-nav_menus .field-attr-title,
+#accordion-panel-nav_menus .field-title-attribute,
 #accordion-panel-nav_menus .field-css-classes,
 #accordion-panel-nav_menus .field-xfn,
@@ -280 +280 @@
 
 #accordion-panel-nav_menus.field-link-target-active .field-link-target,
-#accordion-panel-nav_menus.field-attr-title-active .field-attr-title,
+#accordion-panel-nav_menus.field-title-attribute-active .field-title-attribute,
 #accordion-panel-nav_menus.field-css-classes-active .field-css-classes,
 #accordion-panel-nav_menus.field-xfn-active .field-xfn,

trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php

@@ -166 +166 @@
                     </label>
                 </p>
-                <p class="field-title-attribute description description-wide">
+                <p class="field-title-attribute field-attr-title description description-wide">
                     <label for="edit-menu-item-attr-title-<?php echo $item_id; ?>">
                         <?php _e( 'Title Attribute' ); ?><br />

trunk/src/wp-admin/includes/nav-menu.php

@@ -942 +942 @@
 function wp_nav_menu_manage_columns() {
     return array(
-        '_title'      => __( 'Show advanced menu properties' ),
-        'cb'          => '<input type="checkbox" />',
-        'link-target' => __( 'Link Target' ),
-        'attr-title'  => __( 'Title Attribute' ),
-        'css-classes' => __( 'CSS Classes' ),
-        'xfn'         => __( 'Link Relationship (XFN)' ),
-        'description' => __( 'Description' ),
+        '_title'          => __( 'Show advanced menu properties' ),
+        'cb'              => '<input type="checkbox" />',
+        'link-target'     => __( 'Link Target' ),
+        'title-attribute' => __( 'Title Attribute' ),
+        'css-classes'     => __( 'CSS Classes' ),
+        'xfn'             => __( 'Link Relationship (XFN)' ),
+        'description'     => __( 'Description' ),
     );
 }

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-control.php

@@ -106 +106 @@
                 </label>
             </p>
-            <p class="field-attr-title description description-thin">
+            <p class="field-title-attribute field-attr-title description description-thin">
                 <label for="edit-menu-item-attr-title-{{ data.menu_item_id }}">
                     <?php _e( 'Title Attribute' ); ?><br />