Changeset 37247

Timestamp:

04/19/2016 08:49:38 PM (10 years ago)

Author:

jorbin

Message:

Use px instead of in in device preview

Devices are not consistent in how they handle in units. in was an attempt to cleverly disguise the exact size of the 'tablet'. The PHP code standards mentions avoiding clever code ( ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#clever-code ) but we should extend that idea to the css code as well.

Props celloexpressions
Fixes #36457

File:

• trunk/src/wp-admin/css/themes.css (modified) (1 diff)

trunk/src/wp-admin/css/themes.css

@@ -1593 +1593 @@
 
 .preview-tablet .wp-full-overlay-main {
-        margin: auto 0 auto -3in;
-        width: 6in; /* Size is loosely based on a typical "tablet" device size. Intentionally ambiguous - this does not represent any particular device precisely. */
-        height: 9in;
+        margin: auto 0 auto -360px;
+        width: 720px; /* Size is loosely based on a typical "tablet" device size. Intentionally ambiguous - this does not represent any particular device precisely. */
+        height: 1080px;
         max-height: 100%;
         max-width: 100%;