Changeset 37272 for trunk

Timestamp:

04/21/2016 09:08:11 AM (10 years ago)

Author:

ocean90

Message:

Upgrader: Clear plugin/theme caches directly after a plugin/theme has been updated.

wp_update_plugins() and wp_update_themes() are both hooked into upgrader_process_complete with priority 10. But at this stage the caches in get_plugins(), search_theme_directories(), and wp_get_themes() aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
To reset the caches, wp_clean_themes_cache() and wp_clean_plugins_cache() are now hooked into upgrader_process_complete with priority 9.

This is a follow-up to [34751].

See #34029.
Fixes #36383.

File:

• trunk/src/wp-admin/includes/class-wp-upgrader.php (modified) (8 diffs)

trunk/src/wp-admin/includes/class-wp-upgrader.php

@@ -977 +977 @@
                 add_filter('upgrader_clear_destination', array($this, 'delete_old_plugin'), 10, 4);
                 //'source_selection' => array($this, 'source_selection'), //there's a trac ticket to move up the directory for zip's which are made a bit differently, useful for non-.org plugins.
+                // Clear cache so wp_update_plugins() knows about the new plugin.
+                add_action( 'upgrader_process_complete', 'wp_clean_plugins_cache', 9, 0 );
 
                 $this->run( array(
@@ -991 +993 @@
 
                 // Cleanup our hooks, in case something else does a upgrade on this connection.
+                remove_action( 'upgrader_process_complete', 'wp_clean_plugins_cache', 9 );
                 remove_filter('upgrader_pre_install', array($this, 'deactivate_plugin_before_upgrade'));
                 remove_filter('upgrader_clear_destination', array($this, 'delete_old_plugin'));
@@ -1033 +1036 @@
 
                 add_filter('upgrader_clear_destination', array($this, 'delete_old_plugin'), 10, 4);
+                add_action( 'upgrader_process_complete', 'wp_clean_plugins_cache', 9, 0 );
 
                 $this->skin->header();
@@ -1127 +1131 @@
 
                 // Cleanup our hooks, in case something else does a upgrade on this connection.
+                remove_action( 'upgrader_process_complete', 'wp_clean_plugins_cache', 9 );
                 remove_filter('upgrader_clear_destination', array($this, 'delete_old_plugin'));
 
@@ -1545 +1550 @@
                 add_filter('upgrader_post_install', array($this, 'current_after'), 10, 2);
                 add_filter('upgrader_clear_destination', array($this, 'delete_old_theme'), 10, 4);
+                // Clear cache so wp_update_themes() knows about the new theme.
+                add_action( 'upgrader_process_complete', 'wp_clean_themes_cache', 9, 0 );
 
                 $this->run( array(
@@ -1558 +1565 @@
                 ) );
 
+                remove_action( 'upgrader_process_complete', 'wp_clean_themes_cache', 9 );
                 remove_filter('upgrader_pre_install', array($this, 'current_before'));
                 remove_filter('upgrader_post_install', array($this, 'current_after'));
@@ -1602 +1610 @@
                 add_filter('upgrader_post_install', array($this, 'current_after'), 10, 2);
                 add_filter('upgrader_clear_destination', array($this, 'delete_old_theme'), 10, 4);
+                // Clear cache so wp_update_themes() knows about the new theme.
+                add_action( 'upgrader_process_complete', 'wp_clean_themes_cache', 9, 0 );
 
                 $this->skin->header();
@@ -1678 +1688 @@
 
                 // Cleanup our hooks, in case something else does a upgrade on this connection.
+                remove_action( 'upgrader_process_complete', 'wp_clean_themes_cache', 9 );
                 remove_filter('upgrader_pre_install', array($this, 'current_before'));
                 remove_filter('upgrader_post_install', array($this, 'current_after'));