Changeset 37303 for trunk

Timestamp:

04/22/2016 09:42:38 PM (10 years ago)

Author:

rachelbaker

Message:

Comments: Keep comments safe in the Edit Post screen.

Warns users that have added a new Comment or began editing an existing without saving their changes, before they press the “update” button which would wipe out their comment changes.

Fixes #32818.

Props polevaultweb.

Location:

trunk/src

Files:

• wp-admin/js/edit-comments.js (modified) (5 diffs)
• wp-admin/js/post.js (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-admin/js/edit-comments.js

@@ -567 +567 @@
         cid : '',
         act : '',
+        originalContent : '',
 
         init : function() {
@@ -650 +651 @@
 
                 this.cid = '';
+                this.originalContent = '';
         },
 
@@ -659 +661 @@
                         colspanVal = 0;
 
+                if ( ! this.discardCommentChanges() ) {
+                        return false;
+                }
+
                 t.close();
                 t.cid = comment_id;
@@ -667 +673 @@
                 act = 'edit' == action ? 'edit' : 'replyto';
                 act = t.act = act + '-comment';
+                t.originalContent = $('textarea.comment', rowData).val();
                 colspanVal = $( '> th:visible, > td:visible', c ).length;
 
@@ -854 +861 @@
                         $('#no-comments').remove();
                 });
+        },
+
+        /**
+         * Alert the user if they have unsaved changes on a comment that will be
+         * lost if they proceed.
+         *
+         * @returns {boolean}
+         */
+        discardCommentChanges: function() {
+                var editRow = $( '#replyrow' );
+
+                if  ( this.originalContent === $( '#replycontent', editRow ).val() ) {
+                        return true;
+                }
+
+                return window.confirm( adminCommentsL10n.warnCommentChanges );
         }
 };

trunk/src/wp-admin/js/post.js

@@ -273 +273 @@
                         if ( typeof commentReply !== 'undefined' ) {
                                 /*
+                                 * Warn the user they have an unsaved comment before submitting
+                                 * the post data for update.
+                                 */
+                                if ( ! commentReply.discardCommentChanges() ) {
+                                        return false;
+                                }
+
+                                /*
                                  * Close the comment edit/reply form if open to stop the form
                                  * action from interfering with the post's form action.

trunk/src/wp-includes/script-loader.php

@@ -496 +496 @@
                         'reply' => __( 'Reply' ),
                         'warnQuickEdit' => __( "Are you sure you want to edit this comment?\nThe changes you made will be lost." ),
+                        'warnCommentChanges' => __( "Are you sure you want to do this?\nThe comment changes you made will be lost." ),
                         'docTitleComments' => __( 'Comments' ),
                         /* translators: %s: comments count */