Changeset 37308 for trunk/src/wp-includes/theme.php

Timestamp:

04/26/2016 05:04:25 PM (9 years ago)

Author:

rachelbaker

Message:

Post Thumbnails: When using add_theme_support( ‘post-thumbnails’, array( $post_types) ) merge the supported post_types.

Allow the adding of post-thumbnail support for one or more post_types without unsetting any previously added post_types. This matches the behavior of other uses of add_theme_support() and the expectations of a function with a prefix of “add”.
To unset post-thumbnail support use remove_theme_support() instead.

Fixes #22080

Props alexkingorg, jmichaelward, and flixos90.

File:

• trunk/src/wp-includes/theme.php (modified) (1 diff)

trunk/src/wp-includes/theme.php

@@ -1536 +1536 @@
 
     switch ( $feature ) {
+        case 'post-thumbnails':
+            // All post types are already supported.
+            if ( true === get_theme_support( 'post-thumbnails' ) ) {
+                return;
+            }
+
+            /*
+             * Merge post types with any that already declared their support
+             * for post thumbnails.
+             */
+            if ( is_array( $args[0] ) && is_array( $_wp_theme_features['post-thumbnails'][0] ) ) {
+                $post_types = array_unique( array_merge( $args[0], $_wp_theme_features['post-thumbnails'][0] ) );
+
+                $args = array( $post_types );
+            }
+
+            break;
+
         case 'post-formats' :
             if ( is_array( $args[0] ) ) {