Changeset 37333 for trunk/src/wp-includes/class-wp-widget-factory.php

Timestamp:

04/30/2016 10:35:27 PM (10 years ago)

Author:

westonruter

Message:

Widgets: Provide PHP 5.2 fallback for spl_object_hash() if disabled in logic for registering and unregistering pre-instantiated widgets.

Fixes #28216.

File:

• trunk/src/wp-includes/class-wp-widget-factory.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-widget-factory.php

@@ -47 +47 @@
 
     /**
+     * Memory for the number of times unique class instances have been hashed.
+     *
+     * This can be eliminated in favor of straight spl_object_hash() when 5.3
+     * is the minimum requirement for PHP.
+     *
+     * @since 4.6.0
+     * @access private
+     * @see WP_Widget_Factory::hash_object()
+     *
+     * @var array
+     */
+    private $hashed_class_counts = array();
+
+    /**
+     * Hash an object, doing fallback of `spl_object_hash()` if not available.
+     *
+     * This can be eliminated in favor of straight spl_object_hash() when 5.3
+     * is the minimum requirement for PHP.
+     *
+     * @since 4.6.0
+     * @access private
+     *
+     * @param WP_Widget $widget Widget.
+     * @return string Object hash.
+     */
+    private function hash_object( $widget ) {
+        if ( function_exists( 'spl_object_hash' ) ) {
+            return spl_object_hash( $widget );
+        } else {
+            $class_name = get_class( $widget );
+            $hash = $class_name;
+            if ( ! isset( $widget->_wp_widget_factory_hash_id ) ) {
+                if ( ! isset( $this->hashed_class_counts[ $class_name ] ) ) {
+                    $this->hashed_class_counts[ $class_name ] = 0;
+                }
+                $this->hashed_class_counts[ $class_name ] += 1;
+                $widget->_wp_widget_factory_hash_id = $this->hashed_class_counts[ $class_name ];
+            }
+            $hash .= ':' . $widget->_wp_widget_factory_hash_id;
+            return $hash;
+        }
+    }
+
+    /**
      * Registers a widget subclass.
      *
@@ -57 +101 @@
     public function register( $widget ) {
         if ( $widget instanceof WP_Widget ) {
-            $this->widgets[ spl_object_hash( $widget ) ] = $widget;
+            $this->widgets[ $this->hash_object( $widget ) ] = $widget;
         } else {
             $this->widgets[ $widget ] = new $widget();
@@ -74 +118 @@
     public function unregister( $widget ) {
         if ( $widget instanceof WP_Widget ) {
-            unset( $this->widgets[ spl_object_hash( $widget ) ] );
+            unset( $this->widgets[ $this->hash_object( $widget ) ] );
         } else {
             unset( $this->widgets[ $widget ] );